Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Axis labels, updated Barlist and CategoryBar #1050

Merged
merged 14 commits into from
May 19, 2024
Merged

Conversation

severinlandolt
Copy link
Member

@severinlandolt severinlandolt commented May 19, 2024

Description

This PR:

  • Adds x-axis and y-axis labels to:
    • Area Chart
    • Line Chart
    • Bar Chart
    • Scatter Chart
    • Funnel Chart
  • Removes the value limitation on CategoryBar
  • BarList:
    • Fixes a name type issue
    • Adds a new option "none" to sortOrder
  • Allows overwriting the select width
  • Fixes a tab color bug

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Storybook & Tests

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

severinlandolt and others added 13 commits May 13, 2024 17:58
* update deps

* add missing dep
* fix: chart color loop (#1041)

* chore: revert test data
* fix minWidth

---------

Co-authored-by: Maxime BAUCHET <maxime.bauchet@insystem.fr>
Co-authored-by: severinlandolt <sev.landolt@gmail.com>
* add first draft

* update padding

* update funnel padding constants
…(while more than 1) (#1036)

* feat: CategoryBar now supports values less than 100 or more than 100

* feat: CategoryBar tests for values more than 100 or less than 100

* feat: wrapping some variables into useMemo in CategoryBar

* fix: Consecutive typo in CategoryBar

* lint

* update comments

---------

Co-authored-by: severinlandolt <sev.landolt@gmail.com>
Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 8:28pm

@severinlandolt severinlandolt changed the title feat: TBD feat: New Axis labels, updated Barlist and CategoryBar May 19, 2024
@severinlandolt severinlandolt merged commit 55ecc3e into main May 19, 2024
16 checks passed
Copy link

🎉 This PR is included in version 3.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment