Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(connect-plugin-ethereum): @metamask/eth-sig-util@^7.0.0->^7.0.1 #10378

Merged
merged 1 commit into from
Dec 27, 2023
Merged

deps(connect-plugin-ethereum): @metamask/eth-sig-util@^7.0.0->^7.0.1 #10378

merged 1 commit into from
Dec 27, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Dec 18, 2023 •
edited
Loading

Description

@metamask/eth-sig-util 7.0.1 contains a fix for a regression present in versions 6.0.1 and 7.0.0. Bumping the dependency range ensures that users don't pull in the deprecated 7.0.0.

Release notes:

Changed

  • Remove dependency ethjs-util (#349)

Fixed

  • BREAKING: fix: interpret 0x as hex in bytes encodeField (#354)
    • This fixes a regression introduced in 6.0.1 which caused inconsistent signatures when data was supplied as literal 0x.
  • fix: Exclude test files from published release (#350)
  • fix: Bump @babel/traverse from 7.21.5 to 7.23.2 (#341)

Package diff

@legobeat
Copy link
Contributor Author

legobeat commented Dec 18, 2023 •
edited
Loading

Noting that the latest published version depends on @metamask/eth-sig-util ^6.0.0, which is satisfied by deprecated v6.0.1.

In case a fully backwards-compatible fix is desired, a backport is also available in @metamask/eth-sig-util v6.0.2

@legobeat legobeat mentioned this pull request Dec 18, 2023
Merged
@legobeat legobeat marked this pull request as ready for review December 18, 2023 17:07
@tomasklim tomasklim mentioned this pull request Dec 20, 2023
Merged
@tomasklim tomasklim merged commit e24c80a into trezor:develop Dec 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasklim tomasklim tomasklim approved these changes

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Suite Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @tomasklim