-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837
Draft
jennloe
wants to merge
101
commits into
trilinos:develop
Choose a base branch
from
jennloe:DenseAbstract
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22,711
−3,670
Draft
Changes from all commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
7d7d11f
Added DenseMatrix template param to Belos::MultiVecTraits.
jennloe b0edf1d
Add Dense template paramter to solver manager base class and solver f…
jennloe 477b83b
Remove Serial Dense from ICGSOrthoMgr
jennloe 96295ea
Removed Serial Dense from MatOrthoMgr.
jennloe df26d53
Removed SerialDense from OrthoMgr.
jennloe 941aef2
Added Dense param to blockGMRESIter.
jennloe 0292e2e
Added template param to Gmres iterations.
jennloe f95685a
Add dense param to GMRES sol mgr and base class.
jennloe 8783b12
Added template param to FGmres iter and OrthoMgrFactory.
jennloe c1aae82
First attempt at outlining a few Dense Matrix Traits.
jennloe 1a7908e
Add header file to Belos src needed for Thyra to compile.
jennloe 2bf6b52
Updated DenseMatrixAdapter functions. Wrote a partial Teuchos Serial …
jennloe c2def60
Expanded MultiVec Traits and corresponding Teuchos adapter, which pas…
jennloe 13df066
BlockGmres solver partially running through dense mat traits
jennloe 960a8eb
Add default constructor to dense mat taits.
jennloe 528fa48
Update reshape traits fct to have init to zero option.
jennloe fc139a3
Added more functions for GMRES transition.
jennloe 395e1e6
Converted BlockGmresIter outer layer to use abstract dense.
jennloe d0739e7
Added Frobenius norm to dense traits.
jennloe 151dc13
Converted ICGS to dense abstract interface.
jennloe 1041919
First attempt at Kokkos adapter.
jennloe 224c8e7
Minor adjustment of comments.
jennloe 320c164
Kokkos Dense adapter now passes dense unit test.
jennloe 3aa2c2b
Reorganized Tpetra MV traits to allow future specialization for Kokko…
jennloe 313c464
We now have a working Kokkos::View Dense adapter that is passing basic
jennloe 87d118d
Converted IMGS OrthoMgr to new Dense interface.
jennloe a612e82
Fixed build error in ICGS.
jennloe 0ec1fad
Incorporated Dense Abstract interface into status tests.
jennloe 37ab644
GMRES spaces experiment.
jennloe eb55f67
Converted BelosLSQR and added ValueConst function explicitly in the n…
jennloe 1408eec
Finally got the Kokkos Dense + Tpetra Block GMRES test building and p…
jennloe fe70991
Got DenseMat template param added to all needed solvers at the top le…
jennloe cc67d9a
Test many dense scalar types with SerialDenseMat Teuchos traits, via …
jennloe 1fd4d71
Remove requirement to mark rawptr data modified. Fix two instances of…
jennloe 8215a8e
Added SyncHostToDevice function for DenseMatTraits.
jennloe 27919a7
Added syncs around TRSM. No change in failing test.
jennloe f185d30
Added syncs to LS problem solve. No change in failing test.
jennloe 0294e71
Added extra syncs. Encountering deep copy error. Added debug statemen…
jennloe 94d4e2c
Converted Minres to abstract layer; works with Teuchos dense backend.
jennloe b6ee456
Minres solver converted and runs with KK dense on CPU.
jennloe a758bb3
Fixed a deep copy issue for strided matrices. Also added some couts f…
jennloe 3a10253
Fix Kokkos stride method for dense matrix traits and small code cleanup
hkthorn 25dbff5
Improve integration of dense matrix traits into LSQR
hkthorn e0cc948
Converts BiCGStab and TFQMR solver to use dense matrix template
hkthorn 7a36c9f
Removes unused implicit residual norm status test
hkthorn 86f2a61
Remove unused Teuchos_SerialDenseMatrix.hpp header file
hkthorn d0b2c05
Removes default argument for dense matrix template argument
hkthorn 2c4bb5d
Minor change to binary name for Kokkos::DualView MINRES test
hkthorn e464d9f
Converts PCPG solver to use dense matrix traits
hkthorn 42d9f4e
Removes unused typedef
hkthorn 58718cf
Fixes GCRODR template to include dense matrix argument
hkthorn 3f6e805
Removes duplicate definition of MINRES directory
hkthorn bac24be
Fixes MINRES test so it will compile.
hkthorn d83ce59
Fixes MVOPTester code for Kokkos. Now this test passes on ascicgpu030.
hkthorn 7ae9648
Fixes MINRES solver for Kokkos. Now the MINRES test passes on ascicg…
hkthorn a803a20
Finishes integration of dense matrix traits into PCPG
hkthorn 64db2ef
Fixes all orthogonalization classes and testers to work with dense ma…
hkthorn 3a11dc9
Removes debugging statements
hkthorn df5e218
Changes diagonal updating to use Subview/PutScalar methods
hkthorn 64fe160
Adds Teuchos::SerialDenseMatrix test for DenseMatrixTester
hkthorn 98bfad4
Converts over TSQR classes in Belos to use dense matrix template argu…
hkthorn 22297a6
Converts flexible GMRES to use dense matrix traits and adds test
hkthorn b72580f
Converts fixed-point solver to use dense matrix template
hkthorn 121a8c1
Adds missing override to address build warning
hkthorn b1a8e2a
Removed unnecessary Teuchos SDM header
hkthorn f0ec43d
Moves pseudo-block GMRES data structures to iteration header
hkthorn 9574ca1
Adds override statment to address compiler warning
hkthorn 8b0eebc
Converts single-vector CG, pseudo-block CG, and stochastic CG to DMT
hkthorn af8a58f
Removes unused serial dense matrix objects
hkthorn 573ec2e
Adds DenseSolver interface for block CG solver
hkthorn f17ad3e
Fixes dense solver for Kokkos interface, clean up CG solvers
hkthorn 3e4cce1
Finished converting GMRES-variants to dense matrix traits
hkthorn 0128f03
Adds GMRES resolve test for Kokkos DualView, fixes templates in other…
hkthorn 14ddb95
Fixes compile error for CommandLineProcessor
hkthorn a9dc57e
Fixes OrthoFactory to use dense matrix traits in template argument
hkthorn c97d73f
Inserts missing device to host synchronization
hkthorn 72497f1
Fixing const correctness in arguments
hkthorn 2906ae8
Fixes CreateCopy and GetRawHostPtr, updates test
hkthorn 9b7fe27
Update GCRODR solver to use dense matrix traits
hkthorn 1a24f3d
Adds tests for GCRODR and CG solver using Kokkos::DualView dense matrix
hkthorn 7f1084c
Fix headers to be consistent with recent changes
hkthorn 7927d18
Add complex-valued tests for minres, bicgstab, and gcrodr
hkthorn d4276de
Consolidates Teuchos::ScalarTraits typedefs
hkthorn 6cdbb07
Corrects use of DMT::Value to DMT::ValueConst.
hkthorn 11ae709
Comments out failing BiCGStab test
hkthorn c6d6a2c
Adding new tests to exercise orthogonalization options with GCRODR
hkthorn 279fd1a
Adding method to debugging output to enable better understanding of p…
hkthorn 2a73f52
Completes integration of DenseMatrixTraits
hkthorn d475b4d
Changes scalar values from SerialDenseMatrix to std::vector<>
hkthorn 8a134a3
Moves several dense matrix objects to std::vector objects
hkthorn 938a8c3
Remove unnecessary header
hkthorn 5bc1810
Code cleanup to remove unnecessary dense matrix views
hkthorn 66abf15
Final clean up before dense matrix traits transformation of RCG
hkthorn 1fb7ff7
Convert SerialDenseMatrix objects to dense matrix traits.
hkthorn f104a8c
Cleans up use of MvAddMv to use Assign when more appropriate
hkthorn 5832db1
Finishes migration of GEMM calls to use Teuchos::BLAS class
hkthorn d668fbe
Removes unused one/zero definitions after MvAddMv -> Assign changes
hkthorn e8e54fb
Fixes RCG solver to be correct with Kokkos::DualView
hkthorn 0ed48a1
Removes unused zero and one definitions
hkthorn 4b6ea43
Fix deprecated std::random_shuffle call
hkthorn 21240dc
Update pseudo-block solvers for dense matrix abstraction
hkthorn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove KKGMRESEX in final.