Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Create GitHub action check for detecting addition of MPI_COMM_WORLD #12149

Conversation

JacobDomagala
Copy link
Contributor

Per discussion in #12111

@ccober6
Copy link
Contributor

ccober6 commented Aug 21, 2023

@sebrowne

Copy link
Contributor

@sebrowne sebrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this script detect itself?

@stmcgovern
Copy link
Contributor

stmcgovern commented Aug 22, 2023

Will this script detect itself?

if file_name.endswith((".c", ".cpp", ".h", ".hpp")) and ...

so it shouldn't be looking in a yml or a py.

Thanks for approving @sebrowne . Thanks for making this @JacobDomagala . It looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants