Framework: Update detect-mpi-comm-world GitHub action
#12199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is out of sync with origin/develop
…m-world-usage script, as it may provide incorrect output
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Using the merge base makes sense to me, this is what I've done on a couple of other projects. |
sebrowne
added
the
AT: PRE-TEST INSPECTED
sebrowne
approved these changes
Sep 2, 2023
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
sebrowne
added
the
AT: PRE-TEST INSPECTED
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: JacobDomagala |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sebrowne ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
1 similar comment
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
@JacobDomagala @sebrowne Can this be merged? |
|
Works for me |
jgfouca
added a commit
to jgfouca/Trilinos
that referenced
this pull request
Sep 7, 2023
…stilu * origin/develop: (179 commits) Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199) Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217) teuchos(cleaning): remove old type traits is_same Use ternary in conditionals involving is_contiguous. Extract diagonal blocks from a CRS matrix into separate CRS matrices Tpetra: Update Building.rst Zoltan2: fix shadow warning Stokhos: fix KokkosKernels trilinos#1959 NOX: fix font in screen output Tpetra: fix TAFC changes for UVM enabled Tpetra: remove unnecessary exception test MueLu: remove deep_copy timers Tpetra: fix unit tests, eliminate more deep copies Tpetra: remove obsolete TAFC method Tpetra: merge two TAFC methods MueLu: update lumped diagonal code Tpetra: replace device type of resulting view Belos: Remove use of hardcoded MPI_COMM_WORLD Stokhos: update for new KokkosSparse::spmv overloads Tpetra: Removing the incorrect ETI_DEVICES ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Sep 8, 2023
…s:develop' (9cf8dfb). * trilinos-develop: Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199) Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217) teuchos(cleaning): remove old type traits is_same Remove LFS image objects Use ternary in conditionals involving is_contiguous. Zoltan2: fix shadow warning Belos: Remove use of hardcoded MPI_COMM_WORLD Zoltan2: Fix warnings and formatting Zoltan2: Refactor of BasisVectorAdapter to use Kokkos data structures
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Sep 8, 2023
…s:develop' (9cf8dfb). * trilinos-develop: Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199) Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217) teuchos(cleaning): remove old type traits is_same Remove LFS image objects Use ternary in conditionals involving is_contiguous. Zoltan2: fix shadow warning Belos: Remove use of hardcoded MPI_COMM_WORLD Zoltan2: Fix warnings and formatting Zoltan2: Refactor of BasisVectorAdapter to use Kokkos data structures
sebrowne
pushed a commit
to sebrowne/Trilinos
that referenced
this pull request
Sep 11, 2023
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop * Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
sebrowne
pushed a commit
to sebrowne/Trilinos
that referenced
this pull request
Sep 11, 2023
…stilu * origin/develop: (179 commits) Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199) Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217) teuchos(cleaning): remove old type traits is_same Use ternary in conditionals involving is_contiguous. Extract diagonal blocks from a CRS matrix into separate CRS matrices Tpetra: Update Building.rst Zoltan2: fix shadow warning Stokhos: fix KokkosKernels trilinos#1959 NOX: fix font in screen output Tpetra: fix TAFC changes for UVM enabled Tpetra: remove unnecessary exception test MueLu: remove deep_copy timers Tpetra: fix unit tests, eliminate more deep copies Tpetra: remove obsolete TAFC method Tpetra: merge two TAFC methods MueLu: update lumped diagonal code Tpetra: replace device type of resulting view Belos: Remove use of hardcoded MPI_COMM_WORLD Stokhos: update for new KokkosSparse::spmv overloads Tpetra: Removing the incorrect ETI_DEVICES ...
sebrowne
pushed a commit
to sebrowne/Trilinos
that referenced
this pull request
Sep 11, 2023
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop * Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
sebrowne
pushed a commit
to sebrowne/Trilinos
that referenced
this pull request
Sep 11, 2023
…stilu * origin/develop: (179 commits) Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199) Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217) teuchos(cleaning): remove old type traits is_same Use ternary in conditionals involving is_contiguous. Extract diagonal blocks from a CRS matrix into separate CRS matrices Tpetra: Update Building.rst Zoltan2: fix shadow warning Stokhos: fix KokkosKernels trilinos#1959 NOX: fix font in screen output Tpetra: fix TAFC changes for UVM enabled Tpetra: remove unnecessary exception test MueLu: remove deep_copy timers Tpetra: fix unit tests, eliminate more deep copies Tpetra: remove obsolete TAFC method Tpetra: merge two TAFC methods MueLu: update lumped diagonal code Tpetra: replace device type of resulting view Belos: Remove use of hardcoded MPI_COMM_WORLD Stokhos: update for new KokkosSparse::spmv overloads Tpetra: Removing the incorrect ETI_DEVICES ...
csiefer2
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop * Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
cwpearson
pushed a commit
to cwpearson/Trilinos
that referenced
this pull request
Sep 19, 2023
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop * Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/framework
Fix the issue where base branch is out of sync with Trilinos' develop branch. This results in false positives (removed files or removed lines of
MPI_COMM_WORLDare reported since they're still present on base branch).I also removed the local (uncommited) execution part, since it can produce incorrect results.