Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Belos: Fixed the CG multi-precision test for Tpetra #12225

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Belos: Fixed the CG multi-precision test for Tpetra #12225

merged 2 commits into from
Sep 9, 2023

Conversation

hkthorn
Copy link
Contributor

@hkthorn hkthorn commented Sep 7, 2023

@trilinos/belos

Motivation

The block CG multi-precision test was not built or tested, plus it
had old Tpetra syntax and needed updating. It was similar to the
block GMRES multi-precision test, so it is being replaced with that
test modified to call block CG. Now this new multi-precision test
is being enabled if the float precision is enabled in Tpetra.

After reviewing the tests and examples, it was noticed that the old
Dummy files are still in the repository. They are unnecessary and
are being removed.

Stakeholder Feedback

Testing

OSX Clang MPI/Serial

@hkthorn
Belos: Fixed the CG multi-precision test for Tpetra
bac25eb 
The block CG multi-precision test was not built or tested, plus it
had old Tpetra syntax and needed updating.  It was similar to the
block GMRES multi-precision test, so it is being replaced with that
test modified to call block CG.  Now this new multi-precision test
is being enabled if the float precision is enabled in Tpetra.

After reviewing the tests and examples, it was noticed that the old
Dummy files are still in the repository.  They are unnecessary and
are being removed.
@hkthorn
Merge branch 'trilinos:develop' into develop
3b2e6ef
@hkthorn hkthorn requested a review from jennloe September 7, 2023 16:33
@hkthorn hkthorn self-assigned this Sep 7, 2023
@hkthorn hkthorn added pkg: Belos AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Sep 7, 2023
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 2810
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 1309
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1299
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1298
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 2513
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2301
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 940
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Using Repos:

Repo: TRILINOS (hkthorn/Trilinos)
  • Branch: develop
  • SHA: 3b2e6ef
  • Mode: TEST_REPO

Pull Request Author: hkthorn

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 2810
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 1309
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1299
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1298
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 2513
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2301
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 940
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: Belos;AT: AUTOMERGE
PULLREQUESTNUM 12225
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 3b2e6ef
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8c6ce31


CDash Test Results for PR# 12225.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jennloe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 347a6f2 into trilinos:develop Sep 9, 2023
4 checks passed
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 12225: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Sep 9, 2023
sebrowne pushed a commit to sebrowne/Trilinos that referenced this pull request Sep 11, 2023
@trilinos-autotester @sebrowne
Merge Pull Request trilinos#12225 from hkthorn/Trilinos/develop
a42f2c3 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: b'Belos: Fixed the CG multi-precision test for Tpetra'
PR Author: hkthorn
sebrowne pushed a commit to sebrowne/Trilinos that referenced this pull request Sep 11, 2023
@trilinos-autotester
Merge Pull Request trilinos#12225 from hkthorn/Trilinos/develop
c63c224 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: b'Belos: Fixed the CG multi-precision test for Tpetra'
PR Author: hkthorn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennloe jennloe jennloe approved these changes

@cgcgcg cgcgcg Awaiting requested review from cgcgcg

@csiefer2 csiefer2 Awaiting requested review from csiefer2

Assignees

@hkthorn hkthorn

Labels
pkg: Belos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkthorn @trilinos-autotester @jennloe