Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20240906_175822 branch to master #13432

Merged
merged 32 commits into from
Sep 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0f602c8
tacho: Fix compile errors with Kokkos_ENABLE_IMPL_HIP_UNIFIED_MEMORY=ON.
vbrunini Jul 13, 2024
fd5dc88
amesos2: Fix UMFPACK building with HIP.
vbrunini Jul 13, 2024
826b8ee
minitensor: Fix HIP build error from mismatched KOKKOS_INLINE_FUNCTIO…
vbrunini Aug 15, 2024
cc9944e
Add pre-check job to AT2 workflow to skip dupes
achauphan Aug 22, 2024
f0b3185
Update workflow permissions
achauphan Aug 29, 2024
798fc70
Explicitly cast pt0 + pt1 - 1 term in intrepid2 to ScalarType
malphil Aug 30, 2024
f495f13
Intrepid2: replace CellTopology member in Basis class with its key (#…
mperego Sep 1, 2024
3fa2a33
Piro: update perfanalysis for transient analysis and modify `ThyraPro…
kliegeois Sep 2, 2024
fda77db
Bump actions/upload-artifact from 4.3.6 to 4.4.0
dependabot[bot] Sep 2, 2024
065978f
Bump github/codeql-action from 3.26.5 to 3.26.6
dependabot[bot] Sep 2, 2024
1ae6e2b
STK: Snapshot 09-03-24 08:11 from Sierra 5.21.3-738-g0d57d6ac
alanw0 Sep 3, 2024
61c5817
Merge Pull Request #13417 from trilinos/Trilinos/stk-snapshot
trilinos-autotester Sep 3, 2024
cfcdf62
Add pre-checks job requirement to gcc-serial and gcc-openmpi
achauphan Sep 3, 2024
b4fd996
Remove modification of source tree
sebrowne Sep 3, 2024
22fd8f5
Start to remove unused arguments
sebrowne Sep 3, 2024
32f566b
Merge Pull Request #13416 from trilinos/Trilinos/malachi/intrepid-2-f…
trilinos-autotester Sep 3, 2024
f435a95
Merge Pull Request #13420 from trilinos/Trilinos/dependabot/github_ac…
trilinos-autotester Sep 3, 2024
7b8ca19
Make job number argument optional
sebrowne Sep 3, 2024
08bf7d8
Merge Pull Request #13419 from trilinos/Trilinos/dependabot/github_ac…
trilinos-autotester Sep 4, 2024
22d231a
Force all packages off for Framework testing
sebrowne Sep 4, 2024
5bf9ec2
Fix logic for "no jenkins build number"
sebrowne Sep 4, 2024
5c74c27
Fix help message testing
sebrowne Sep 4, 2024
6cf4a8e
Clean up all RHEL7 configurations
sebrowne Sep 4, 2024
f6f4796
Finish removing unused section
sebrowne Sep 4, 2024
0ac0665
Merge Pull Request #13421 from sebrowne/Trilinos/fix-at2-update-column
trilinos-autotester Sep 5, 2024
13092ec
Intrepid2: Fix inclusion test
mperego Sep 5, 2024
7882311
Merge Pull Request #13383 from achauphan/Trilinos/add-prechecks-job
trilinos-autotester Sep 5, 2024
09dac29
Merge Pull Request #13425 from sebrowne/Trilinos/clean-rhel7-configs
trilinos-autotester Sep 6, 2024
cc74003
STK: Snapshot 09-06-24 06:21 from Sierra 5.21.4-85-gd1ee7818
alanw0 Sep 6, 2024
002d398
Merge Pull Request #13426 from trilinos/Trilinos/stk-snapshot
trilinos-autotester Sep 6, 2024
446b5b0
Merge pull request #13366 from vbrunini/hip_unified_memory
ndellingwood Sep 6, 2024
869d1df
Merge Pull Request #13428 from mperego/Trilinos/intrepid2_fixinclusion
trilinos-autotester Sep 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions .github/workflows/AT2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,27 @@ on:
- develop
workflow_dispatch:

# actions: write needed by skip-duplicate-actions
permissions:
actions: write
contents: read

jobs:
# Jobs depend on the output of pre-checks to run
pre-checks:
runs-on: ubuntu-latest
outputs:
should_skip: ${{ steps.skip_check.outputs.should_skip }}
steps:
- id: skip_check
uses: fkirc/skip-duplicate-actions@v5
with:
skip_after_successful_duplicate: 'true'

gcc10-openmpi416-EXPERIMENTAL:
needs: pre-checks
runs-on: [self-hosted, gcc-10.3.0_openmpi-4.1.6]
if: ${{ github.event.action == 'synchronize' || github.event.action == 'opened' || github.event.review.state == 'APPROVED' }}
if: ${{ needs.pre-checks.outputs.should_skip != 'true' && (github.event.action == 'synchronize' || github.event.action == 'opened' || github.event.review.state == 'APPROVED') }}
steps:
- name: env
env:
Expand Down Expand Up @@ -71,19 +85,14 @@ jobs:
export PYTHONPATH=${PYTHONPATH}:${GITHUB_WORKSPACE}/packages/framework/GenConfig
export PYTHONPATH=${PYTHONPATH}:${GITHUB_WORKSPACE}/packages/framework/pr_tools

sed -i "/\[rhel8\]/a `cat /etc/hostname`" /home/runner/_work/Trilinos/Trilinos/packages/framework/ini-files/supported-systems.ini
printf "\n\n\n"

echo "image: ${AT2_IMAGE:-unknown}"

python3 ${GITHUB_WORKSPACE}/packages/framework/pr_tools/PullRequestLinuxDriverTest.py \
--source-repo-url ${GITHUB_WORKSPACE} \
--target-repo-url ${GITHUB_WORKSPACE} \
--target-branch-name ${{ github.event.pull_request.base.ref }} \
--pullrequest-build-name PR-${{ github.event.pull_request.number }} \
--genconfig-build-name rhel8_gcc-openmpi_debug_shared_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables \
--pullrequest-number ${{ github.event.pull_request.number }} \
--jenkins-job-number 0 \
--pullrequest-env-config-file ${GITHUB_WORKSPACE}/packages/framework/pr_tools/trilinos_pr.ini \
--pullrequest-gen-config-file ${GITHUB_WORKSPACE}/packages/framework/GenConfig/src/gen-config.ini \
--workspace-dir /home/runner/_work/Trilinos \
Expand All @@ -96,8 +105,9 @@ jobs:
--filename-packageenables ./packageEnables.cmake

gcc830-serial-EXPERIMENTAL:
needs: pre-checks
runs-on: [self-hosted, gcc-8.3.0_serial]
if: ${{ github.event.action == 'synchronize' || github.event.action == 'opened' || github.event.review.state == 'APPROVED' }}
if: ${{ needs.pre-checks.outputs.should_skip != 'true' && (github.event.action == 'synchronize' || github.event.action == 'opened' || github.event.review.state == 'APPROVED') }}
steps:
- name: env
env:
Expand Down Expand Up @@ -149,19 +159,14 @@ jobs:
export PYTHONPATH=${PYTHONPATH}:${GITHUB_WORKSPACE}/packages/framework/GenConfig
export PYTHONPATH=${PYTHONPATH}:${GITHUB_WORKSPACE}/packages/framework/pr_tools

sed -i "/\[rhel8\]/a `cat /etc/hostname`" /home/runner/_work/Trilinos/Trilinos/packages/framework/ini-files/supported-systems.ini
printf "\n\n\n"

echo "image: ${AT2_IMAGE:-unknown}"

python3 ${GITHUB_WORKSPACE}/packages/framework/pr_tools/PullRequestLinuxDriverTest.py \
--source-repo-url ${GITHUB_WORKSPACE} \
--target-repo-url ${GITHUB_WORKSPACE} \
--target-branch-name ${{ github.event.pull_request.base.ref }} \
--pullrequest-build-name PR-${{ github.event.pull_request.number }} \
--genconfig-build-name rhel8_gcc-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables \
--pullrequest-number ${{ github.event.pull_request.number }} \
--jenkins-job-number 0 \
--pullrequest-env-config-file ${GITHUB_WORKSPACE}/packages/framework/pr_tools/trilinos_pr.ini \
--pullrequest-gen-config-file ${GITHUB_WORKSPACE}/packages/framework/GenConfig/src/gen-config.ini \
--workspace-dir /home/runner/_work/Trilinos \
Expand All @@ -174,8 +179,9 @@ jobs:
--filename-packageenables ./packageEnables.cmake

cuda11-uvm-EXPERIMENTAL:
needs: pre-checks
runs-on: [self-hosted, cuda-11.4.2_gcc-10.3.0_openmpi-4.1.6]
if: ${{ github.event.action == 'synchronize' || github.event.action == 'opened' || github.event.review.state == 'APPROVED' }}
if: ${{ needs.pre-checks.outputs.should_skip != 'true' && (github.event.action == 'synchronize' || github.event.action == 'opened' || github.event.review.state == 'APPROVED') }}
steps:
- name: env
env:
Expand Down Expand Up @@ -226,19 +232,14 @@ jobs:
export PYTHONPATH=${PYTHONPATH}:${GITHUB_WORKSPACE}/packages/framework/GenConfig
export PYTHONPATH=${PYTHONPATH}:${GITHUB_WORKSPACE}/packages/framework/pr_tools

sed -i "/\[rhel8\]/a `cat /etc/hostname`" /home/runner/_work/Trilinos/Trilinos/packages/framework/ini-files/supported-systems.ini
printf "\n\n\n"

echo "image: ${AT2_IMAGE:-unknown}"
type python
python3 ${GITHUB_WORKSPACE}/packages/framework/pr_tools/PullRequestLinuxDriverTest.py \
--source-repo-url ${GITHUB_WORKSPACE} \
--target-repo-url ${GITHUB_WORKSPACE} \
--target-branch-name ${{ github.event.pull_request.base.ref }} \
--pullrequest-build-name PR-${{ github.event.pull_request.number }} \
--genconfig-build-name rhel8_cuda-gcc-openmpi_release_static_Ampere80_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables \
--pullrequest-number ${{ github.event.pull_request.number }} \
--jenkins-job-number 0 \
--pullrequest-env-config-file ${GITHUB_WORKSPACE}/packages/framework/pr_tools/trilinos_pr.ini \
--pullrequest-gen-config-file ${GITHUB_WORKSPACE}/packages/framework/GenConfig/src/gen-config.ini \
--workspace-dir /home/runner/_work/Trilinos \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clang_format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- run: git diff HEAD > format_patch.txt
- run: if [ "$(cat format_patch.txt)" == "" ] ; then rm format_patch.txt ; else cat format_patch.txt; fi

- uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
- uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
id: upload-artf
if: ${{ hashFiles('format_patch.txt') != '' }}
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@2c779ab0d087cd7fe7b826087247c2c81f27bfa6 # v3.26.5
uses: github/codeql-action/init@4dd16135b69a43b6c8efb853346f8437d92d3c93 # v3.26.6
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
Expand All @@ -85,6 +85,6 @@ jobs:
make -j 2

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@2c779ab0d087cd7fe7b826087247c2c81f27bfa6 # v3.26.5
uses: github/codeql-action/analyze@4dd16135b69a43b6c8efb853346f8437d92d3c93 # v3.26.6
with:
category: "/language:${{matrix.language}}"
4 changes: 2 additions & 2 deletions .github/workflows/scorecards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ jobs:
# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: "Upload artifact"
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
with:
name: SARIF file
path: results.sarif
retention-days: 5

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@2c779ab0d087cd7fe7b826087247c2c81f27bfa6 # v3.26.5
uses: github/codeql-action/upload-sarif@4dd16135b69a43b6c8efb853346f8437d92d3c93 # v3.26.6
with:
sarif_file: results.sarif
16 changes: 8 additions & 8 deletions packages/amesos2/src/Amesos2_Umfpack_FunctionMap.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,16 @@ namespace Amesos2 {
#ifdef HAVE_TEUCHOS_COMPLEX

template <>
struct FunctionMap<Umfpack,std::complex<double>>
struct FunctionMap<Umfpack,Kokkos::complex<double>>
{
typedef TypeMap<Umfpack,std::complex<double>> type_map;
typedef TypeMap<Umfpack,Kokkos::complex<double>> type_map;

/**
* \brief Binds to the appropriate Umfpack solver driver based on data type
*/

static double * stdComplexToUmfpackDoubleConversion(
const std::complex<double> v [ ])
const Kokkos::complex<double> v [ ])
{
return (double*)(&v[0]);
}
Expand All @@ -116,9 +116,9 @@ namespace Amesos2 {
int sys,
const int Ap [ ],
const int Ai [ ],
const std::complex<double> Ax [ ],
std::complex<double> X [ ],
const std::complex<double> B [ ],
const Kokkos::complex<double> Ax [ ],
Kokkos::complex<double> X [ ],
const Kokkos::complex<double> B [ ],
void *Numeric,
const double Control [UMFPACK_CONTROL],
double Info [UMFPACK_INFO])
Expand All @@ -133,7 +133,7 @@ namespace Amesos2 {
static int umfpack_numeric(
const int Ap [ ],
const int Ai [ ],
const std::complex<double> Ax [ ],
const Kokkos::complex<double> Ax [ ],
void *Symbolic,
void **Numeric,
const double Control[UMFPACK_CONTROL],
Expand All @@ -147,7 +147,7 @@ namespace Amesos2 {
int n_col,
const int Ap [ ],
const int Ai [ ],
const std::complex<double> Ax [ ],
const Kokkos::complex<double> Ax [ ],
void **Symbolic,
const double Control [UMFPACK_CONTROL],
double Info [UMFPACK_INFO])
Expand Down
4 changes: 2 additions & 2 deletions packages/amesos2/src/Amesos2_Umfpack_TypeMap.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,14 @@ struct TypeMap<Umfpack,double>
template <>
struct TypeMap<Umfpack,std::complex<float> > // provide conversion from std::complex<float> to std::complex<double>
{
typedef std::complex<double> type;
typedef Kokkos::complex<double> type;
typedef double magnitude_type;
};

template <>
struct TypeMap<Umfpack,std::complex<double> >
{
typedef std::complex<double> type;
typedef Kokkos::complex<double> type;
typedef double magnitude_type;
};

Expand Down
Loading
Loading