-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stokhos: refactor create_mirror
specialisation for View
of MP::Vector
#13433
Stokhos: refactor create_mirror
specialisation for View
of MP::Vector
#13433
Conversation
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Hi @etphipp. Thanks for taking a look and giving a thumps up. You forgot to set the labels :) Would you have a moment to set them to launch the test pipeline? Thanks! |
Done, sorry about that. |
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: maartenarnst |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]! |
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
Merge on Pull Request# 13433: IS A SUCCESS - Pull Request successfully merged |
@trilinos/stokhos
@etphipp
@romintomasetti
@pzehner
This PR refactors the
Stokhos
specialisation ofKokkos::create_mirror
forView
ofMP::Vector
. This refactoring is motivated by recent changes inKokkos
in:create_mirror*
toImpl::create_mirror*
kokkos/kokkos#7061In that
Kokkos
PR, additional constraints were imposed in the public interface ofKokkos::create_mirror
andKokkos::create_mirror_view
. In particular, the version ofKokkos::create_mirror_view
that takes aKokkos::Impl::ViewCtorProp
now no longer works with views with a non-voidspecialize
trait.This PR thus adds to Stokhos a specialisation of
Kokkos::create_mirror
that takes aKokkos::Impl::ViewCtorProp
. Then, all other overloads are refactor to map to that version. And, in the end, a specialisation ofKokkos::create_mirror_view
is added.We may want to explore with the
Kokkos
team whether the new constraint (std::is_void_v<typename ViewTraits<T, P...>::specialize>
) on their public version ofKokkos::create_mirror_view
is really needed. If this constraint could be removed there, the new specialisation ofKokkos::create_mirror_view
in this PR could be removed. But the refactoring ofcreate_mirror
in this PR would still be useful.@etphipp, would you have a moment to take a look? Thanks in advance!