Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creds from env, 1sec wait_timeout #6

Merged
merged 2 commits into from
Jun 21, 2023
Merged

creds from env, 1sec wait_timeout #6

merged 2 commits into from
Jun 21, 2023

Conversation

slorello89
Copy link
Contributor

No description provided.

Spartee
Spartee reviewed Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise seems good to me.

src/redis_cache.cc Show resolved Hide resolved
rmccorm4
rmccorm4 reviewed Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@rmccorm4 rmccorm4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I added a test. Will wait to check it's passing before approving.

rmccorm4
rmccorm4 reviewed Jun 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@slorello89 @rmccorm4
Update README.md
3ac04a8 
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
rmccorm4 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes, LGTM

@rmccorm4 rmccorm4 merged commit f4c0303 into main Jun 21, 2023
@slorello89 slorello89 deleted the config-tweaks branch June 22, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spartee Spartee Spartee left review comments

@rmccorm4 rmccorm4 rmccorm4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slorello89 @Spartee @rmccorm4