Skip to content

Commit

Permalink
Fix latent bug in DWARF test case
Browse files Browse the repository at this point in the history
On my branch that replaces the DWARF psymtab reader,
dw2-stack-boundary.exp started failing.  However, when I look at the
output in gdb.log, it is correct:

    file /home/tromey/gdb/build/gdb/testsuite/outputs/gdb.dwarf2/dw2-stack-boundary/dw2-stack-boundary
    Reading symbols from /home/tromey/gdb/build/gdb/testsuite/outputs/gdb.dwarf2/dw2-stack-boundary/dw2-stack-boundary...
    During symbol reading: location description stack overflow
    During symbol reading: location description stack underflow

What happens to cause the failure is that the two branches in
gdb_test_multiple appear in this order:

    -re "\r\nDuring symbol reading: location description stack underflow" {
    [...]
    -re "\r\nDuring symbol reading: location description stack overflow" {

The first one will match the above, without causing the second one to
ever match -- leading to a spurious failure.

Anchoring the regexps seems to fix the problem, and works for the
current gdb as well.
  • Loading branch information
tromey committed Oct 31, 2021
1 parent 2a8f1f4 commit 6e19544
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ gdb_test_multiple "file $binfile" "file command" {
-re "\r\nReading symbols from \[^\r\n\]*\\.\\.\\." {
exp_continue
}
-re "\r\nDuring symbol reading: location description stack underflow" {
-re "^\r\nDuring symbol reading: location description stack underflow" {
set w1 1
exp_continue
}
-re "\r\nDuring symbol reading: location description stack overflow" {
-re "^\r\nDuring symbol reading: location description stack overflow" {
set w2 1
exp_continue
}
Expand Down

0 comments on commit 6e19544

Please sign in to comment.