NAS-130745 / 25.04 / Update smartctl usage to use JSON #14479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiden3c
force-pushed
the
NAS-130745
branch
2 times, most recently
from
ab0d655
to
fa3011d
Compare
aiden3c
changed the title
themylogin
requested changes
Sep 12, 2024
yocalebo
requested changes
Sep 13, 2024
|
New passing tests! |
themylogin
requested changes
Sep 18, 2024
themylogin
approved these changes
Sep 18, 2024
yocalebo
approved these changes
Sep 18, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated our smartctl usage throughout middleware to use the JSON flag to get serialized data. Unfortunately I haven't been able to run this through a full gauntlet of SMART test types for different drives. Going through the smartmontools source code and doing what I can with different drive types I had available, I've gotten the JSON parsing as accurate as I could.
This is something that might end up breaking, but getting tickets will let us fix any assumed/implicit keys we're accessing.
Passing tests, but the majority are our
CI buildtests, which are passing.