Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131350 / 25.04 / Fix failing build #14557

Closed
wants to merge 1 commit into from
Closed

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Sep 21, 2024

This commit adds changes to move IANA numbers to trash as outlined by https://github.com/truenas/middleware/pull/13868/files because they are now coming from ipmitool we have in debian, however they have a decent diff from the URI we are pulling from and the comment there outlines it needs to be a version after 1.18.9-4 but we are still at the same version. So with this change, we remove the enterprise-numbers.txt file coming from ipmitool and keep on pulling our own instead.

This commit adds changes to move IANA numbers to trash as outlined by https://github.com/truenas/middleware/pull/13868/files because they are now coming from ipmitool we have in debian, however they have a decent diff from the URI we are pulling from and the comment there outlines it needs to be a version after 1.18.9-4 but we are still at the same version.
@sonicaj sonicaj added the jira label Sep 21, 2024
@sonicaj sonicaj requested a review from a team September 21, 2024 22:33
@sonicaj sonicaj self-assigned this Sep 21, 2024
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title Fix failing build NAS-131350 / 25.04 / Fix failing build Sep 21, 2024
@truenas truenas deleted a comment from bugclerk Sep 21, 2024
@sonicaj
Copy link
Member Author

sonicaj commented Sep 21, 2024

Closing this in favor of #14558

@sonicaj sonicaj closed this Sep 21, 2024
@sonicaj sonicaj deleted the fix-broken-build-ft branch September 21, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants