NAS-131373 / 25.04 / Fix serialization error #14568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
1 similar comment
themylogin
reviewed
Sep 24, 2024
|
Actually, getting some CI errors, putting WIP tag on |
yocalebo
reviewed
Sep 24, 2024
themylogin
approved these changes
Sep 24, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
eng-gpu-dev106.dc1, when running the recent SMART changes, we get errors related to JSON serialization. Updating the return type to convert our SelfTest classes to dicts was an effective solution. Putting these changes ontoeng-gpu-dev106.dc1fixes the serialization error and everything shows up as it should.