NAS-129639 / 25.04 / Remove unused API endpoints #14576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
themylogin
force-pushed
the
NAS-129639
branch
2 times, most recently
from
2826848
to
94f45bf
Compare
themylogin
force-pushed
the
NAS-129639
branch
from
94f45bf
to
856dcd3
Compare
sonicaj
reviewed
Sep 30, 2024
| @@ -47,17 +47,6 @@ async def ec_curve_choices(self): | |||
| """ | |||
| return {k: k for k in EC_CURVES} | |||
|
|
|||
| @accepts() | |||
There was a problem hiding this comment.
Are we certain UI is not using these ?
There was a problem hiding this comment.
Yes, no removed endpoints are used by the UI. @undsoft are those just hardcoded?
| *[Dict(profile, additional_attrs=True) for profile in CSR_PROFILES], | ||
| example=CSR_PROFILES, | ||
| )) | ||
| async def certificate_signing_requests_profiles(self): |
There was a problem hiding this comment.
UI should be using this for CSR profiles, seems like they are using the wrong endpoint atm
There was a problem hiding this comment.
@undsoft it is strange that the UI does not use this
| @@ -9,22 +8,6 @@ class Config: | |||
| namespace = 'system.advanced' | |||
| cli_namespace = 'system.advanced' | |||
|
|
|||
| @accepts(roles=['SYSTEM_ADVANCED_READ']) | |||
| @returns(Dict(additional_attrs=True)) | |||
| def get_gpu_pci_choices(self): | |||
There was a problem hiding this comment.
This is being used by UI as well iirc, @Qubad786 can you confirm ?
There was a problem hiding this comment.
It seems UI is using device.get_info right now but it should be using this endpoint instead and i think we already have a ticket for UI to use this endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.