Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131370 / 24.10.0 / Fix post mount actions execution on system dataset setup (by Qubad786) #14586

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

bugclerk
Copy link
Contributor

Problem

When system dataset is being migrated, if we have a pool from where it i being migrated - we are temporarily mounting it to another location before it is mounted at it's rightful place so we can copy over data.
However during this transition, we have post mount actions being executed which is not alright and can trigger different failures which in the case i ended up finding this was an issue related to netdata setup not being properly executed.

Solution

Ensure all post mount actions only when the system dataset is mounted at it's rightful place i.e /var/db/system. Additionally, permissions for ix-state directory in netdata are corrected if any exception occurs on the first time system tries to setup netdata.

Original PR: #14567
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131370

@yocalebo yocalebo merged commit 412d4b5 into stable/electriceel Sep 27, 2024
1 of 2 checks passed
@yocalebo yocalebo deleted the NAS-131370-24.10.0 branch September 27, 2024 11:16
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants