Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131446 / 25.04 / Fix enclosure alert #14594

Merged
merged 3 commits into from
Sep 30, 2024
Merged

NAS-131446 / 25.04 / Fix enclosure alert #14594

merged 3 commits into from
Sep 30, 2024

Conversation

yocalebo
Copy link
Contributor

Starting in FT, most everyone has migrated over to using the new enclosure plugin. However, we still have some straggling code using the old enclosure logic. This updates the enclosure alert to use the new enclosure plugin.

Summary of what was done:

  1. remove the legacy z-series hardware checks (this platform has been EOL for years and we no longer provide support on it at all)
  2. update the logic to use the new enclosure plugin (NOTE: using a frozen dataclass since it's much more memory efficient and we're caching all bad elements on the class during runtime)
  3. use a bit of type annotations and clarify variable names to make it more human readable
  4. fix the formatting of the file while i'm here

@yocalebo yocalebo added the jira label Sep 30, 2024
@yocalebo yocalebo requested a review from a team September 30, 2024 13:41
@yocalebo yocalebo changed the title Fix enc alert Fix enclosure alert Sep 30, 2024
@bugclerk bugclerk changed the title Fix enclosure alert NAS-131446 / 25.04 / Fix enclosure alert Sep 30, 2024
@bugclerk
Copy link
Contributor

@truenas truenas deleted a comment from bugclerk Sep 30, 2024
@yocalebo yocalebo merged commit 82ae278 into master Sep 30, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the fix-enc-alert branch September 30, 2024 14:40
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants