NAS-131445 / 25.04 / Add tests for SMB protocol NULL and empty DACL behavior #14597
+181
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
mgrimesix
approved these changes
Sep 30, 2024
bmeagherix
reviewed
Sep 30, 2024
| username=unprivileged_user_fixture.username, | ||
| password=unprivileged_user_fixture.password, | ||
| ) as c: | ||
| fh = c.create_file('test_null_dacl', 'w') |
There was a problem hiding this comment.
Should the filename here be test_empty_dacl ?
There was a problem hiding this comment.
Yeah, I'll change the name.
Comment on lines
111
to
112
| new_sd = c.get_sd(fh, security.SECINFO_OWNER | security.SECINFO_GROUP) | ||
| assert new_sd.dacl.num_aces == 0 |
There was a problem hiding this comment.
If this is an empty DACL test, then how would we have permissions to read this thru SMB?
There was a problem hiding this comment.
We can access by virtue of being the file owner (trump card).
A NULL DACL should grant all users full control of the file. An empty DACL should grant no rights to the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.