Remove VRS values from receipt. Match JSONRPC spec (#549)

* Remove VRS values from receipt. Match JSONRPC spec * Add tests to ensure vrs feilds are not in receipts
trufflesuite · Feb 12, 2020 · b533bea · b533bea
1 parent 9d50099
commit b533bea
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/subproviders/geth_api_double.js b/lib/subproviders/geth_api_double.js
@@ -11,6 +11,7 @@ const { BlockOutOfRangeError } = require("../utils/errorhelper");
 var Subprovider = require("web3-provider-engine/subproviders/subprovider.js");
 
 const maxSafeInt = "0x" + Number.MAX_SAFE_INTEGER.toString(16);
+const vrs = ["v", "r", "s"];
 
 inherits(GethApiDouble, Subprovider);
 
@@ -220,6 +221,9 @@ GethApiDouble.prototype.eth_getTransactionReceipt = function(hash, callback) {
 
     if (receipt && receipt.block) {
       result = receipt.toJSON();
+      vrs.forEach((element) => {
+        delete result[element];
+      });
     }
     callback(null, result);
   });

diff --git a/test/requests.js b/test/requests.js
@@ -1280,9 +1280,9 @@ const tests = function(web3) {
 
       assert.notStrictEqual(receipt, null, "Transaction receipt shouldn't be null");
       assert.notStrictEqual(contractAddress, null, "Transaction did not create a contract");
-      assert.strictEqual(hasOwnProperty.call(receipt, "v"), true, "Transaction includes v signature parameter");
-      assert.strictEqual(hasOwnProperty.call(receipt, "r"), true, "Transaction includes r signature parameter");
-      assert.strictEqual(hasOwnProperty.call(receipt, "s"), true, "Transaction includes s signature parameter");
+      assert.strictEqual(hasOwnProperty.call(receipt, "v"), false, "Transaction includes v signature parameter");
+      assert.strictEqual(hasOwnProperty.call(receipt, "r"), false, "Transaction includes r signature parameter");
+      assert.strictEqual(hasOwnProperty.call(receipt, "s"), false, "Transaction includes s signature parameter");
     });
 
     it("should verify the transaction immediately (eth_getTransactionByHash)", async function() {