Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Remove VRS values from receipt. Match JSONRPC spec #549

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Remove VRS values from receipt. Match JSONRPC spec #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c5078a
Remove VRS values from receipt. Match JSONRPC spec
nicholasjpaterno Feb 11, 2020
c29bd37
Add tests to ensure vrs feilds are not in receipts
nicholasjpaterno Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/subproviders/geth_api_double.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const { BlockOutOfRangeError } = require("../utils/errorhelper");
var Subprovider = require("web3-provider-engine/subproviders/subprovider.js");

const maxSafeInt = "0x" + Number.MAX_SAFE_INTEGER.toString(16);
const vrs = ["v", "r", "s"];

inherits(GethApiDouble, Subprovider);

Expand Down Expand Up @@ -220,6 +221,9 @@ GethApiDouble.prototype.eth_getTransactionReceipt = function(hash, callback) {

if (receipt && receipt.block) {
result = receipt.toJSON();
vrs.forEach((element) => {
delete result[element];
});
}
callback(null, result);
});
Expand Down
6 changes: 3 additions & 3 deletions test/requests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,9 +1280,9 @@ const tests = function(web3) {

assert.notStrictEqual(receipt, null, "Transaction receipt shouldn't be null");
assert.notStrictEqual(contractAddress, null, "Transaction did not create a contract");
assert.strictEqual(hasOwnProperty.call(receipt, "v"), true, "Transaction includes v signature parameter");
assert.strictEqual(hasOwnProperty.call(receipt, "r"), true, "Transaction includes r signature parameter");
assert.strictEqual(hasOwnProperty.call(receipt, "s"), true, "Transaction includes s signature parameter");
assert.strictEqual(hasOwnProperty.call(receipt, "v"), false, "Transaction includes v signature parameter");
assert.strictEqual(hasOwnProperty.call(receipt, "r"), false, "Transaction includes r signature parameter");
assert.strictEqual(hasOwnProperty.call(receipt, "s"), false, "Transaction includes s signature parameter");
});

it("should verify the transaction immediately (eth_getTransactionByHash)", async function() {
Expand Down