Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat: add evm_unlockUnknownAccount #630

Merged
merged 29 commits into from
Sep 15, 2020
Merged

Conversation

davidmurdoch
Copy link
Member

@davidmurdoch davidmurdoch commented Sep 15, 2020

Accidentally permanently closed the previous PR. Reopening here.

This feature is much-needed for on the fly transaction creation, I hope you accept this PR! I can write more tests if required

@aaryamannchallani

@davidmurdoch
Copy link
Member Author

@aaryamannchallani I pushed my local develop branch, instead of the PR branch, to your PR, which resulted in the PR being permanently closed. Sorry about that. I've pushed the correct branch up here and reopened the PR. I'll continue the Code review here.

@davidmurdoch
Copy link
Member Author

@aaryamannchallani Nevermind! It seems I cannot give you write-access to just this branch, so I'll make the necessary changes myself.

will it be in the next version slightly_smiling_face

Yes, I'm planning on shipping this in the next beta release.

@coveralls
Copy link

coveralls commented Sep 15, 2020

Coverage Status

Coverage increased (+44.1%) to 82.697% when pulling f9476ab on aaryamannchallani-develop into a581d91 on develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants