Transfered environment variables from package.json to .env file

[swisstackle]

As of #5134 I was asked to create a PR to push the changes I have made to resolve the Dashboard Windows capability issues.

Perhaps we could just write "set DISABLE_ESLINT_PLUGIN=true && set SKIP_PREFLIGHT_CHECK=true && craco build" as this is the commandline syntax for Windows but I think that an env file is easier and cross platform compatible.

@benjamincburns

[benjamincburns]

Thanks for this change, @swisstackle!

[benjamincburns]

Actually would you mind changing this to use cross-env instead of the .env file?

This is because in the cases where we tend to use .env files we tend to use them for local-only config that shouldn't be committed. Using such a file here in another context might introduce a future security problem where someone thinks they've added a secret to their local .env and winds up committing it.

Also thanks to @michaeljohnbennett for catching this on review!

[swisstackle]

@benjamincburns Ok will do. Should I add cross-env as a dependency with yarn in /truffle or only in /truffle/packages/dashboard/package.json?

[benjamincburns]

@benjamincburns Ok will do. Should I add cross-env as a dependency with yarn in /truffle or only in /truffle/packages/dashboard/package.json?

Just in the dashboard package is fine, thanks!