Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAI-917: Add error message capturing within Python models #137

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

RobGeada
Copy link
Collaborator

@RobGeada RobGeada commented Dec 19, 2022

If we log and capture error messages from within the predict_fun we can display them before the JVM crashes, making debugging a whole lot easier.

Before:
Screenshot 2022-12-19 at 3 09 13 PM

After:
Screenshot 2022-12-19 at 3 14 04 PM

@RobGeada RobGeada marked this pull request as ready for review December 19, 2022 15:14
Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruivieira ruivieira merged commit 7cdaf67 into main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants