Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLamaSharpEmbeddings Exception: EmbeddingMode must be true. #343

Closed
OctavioUlla opened this issue Jun 14, 2024 · 1 comment · Fixed by #344
Closed

LLamaSharpEmbeddings Exception: EmbeddingMode must be true. #343

OctavioUlla opened this issue Jun 14, 2024 · 1 comment · Fixed by #344
Labels
bug Something isn't working enhancement New feature or request

Comments

@OctavioUlla
Copy link
Contributor

Describe the bug

When creating a LlamaSharpEmbeddings the LlamaEmbedder expects the property EmbeddingMode to be true, even if i set it to true in the LlamaSharpConfiguration it is not beign passed to the model params.
image
image
This is the LlamaSharp code that throws the exception:
image

Steps to reproduce the bug

  1. Create a LLamaSharpEmbeddings

Expected behavior

Adding this line of code should fix the problem:
image

Screenshots

No response

NuGet package version

No response

Additional context

No response
@OctavioUlla OctavioUlla added the bug Something isn't working label Jun 14, 2024
@HavenDV HavenDV added the enhancement New feature or request label Jun 14, 2024
@HavenDV
Copy link
Contributor

HavenDV commented Jun 14, 2024

Hello.
Thanks, I think this problem is due to the fact that the LLamaSharp provider was originally written for version 0.8, but after that it was incorrectly updated to new versions
I'll be happy to accept PR on this or take a look at it this weekend

OctavioUlla added a commit to OctavioUlla/LangChain that referenced this issue Jun 14, 2024
@OctavioUlla
Fix: tryAGI#343 - LlamaSharpEmbeddings: EmbeddingMode must be true ex…
b9c62d2 
…ception fixed by passing the embeddingMode condiguration to the LlamaEmbedder
@OctavioUlla OctavioUlla mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: #343 - LLamaSharpEmbeddings Exception: EmbeddingMode must be true OctavioUlla/LangChain
2 participants
@HavenDV @OctavioUlla