fix set google credentials

[danijerez]

I forgot to set the credentials in the client builder.

Summary by CodeRabbit

• New Features
  • Enhanced credential management for Google AI Platform integration, ensuring proper configuration during initialization.
• Bug Fixes
  • Corrected instantiation behavior of VertexAIConfiguration by removing default value for GoogleCredential, requiring explicit assignment.

[coderabbitai]

Walkthrough

The recent changes enhance the VertexAIConfiguration and VertexAIProvider classes by refining how Google credentials are managed. The default initialization of the GoogleCredential property has been removed, requiring explicit configuration. In the VertexAIProvider, the constructor now ensures that the credential is correctly assigned to the PredictionServiceClientBuilder, improving the handling of authentication for API requests.

Changes

Files	Change Summary
src/Providers/Google.VertexAI/src/VertexAIConfiguration.cs src/Providers/Google.VertexAI/src/VertexAIProvider.cs	The GoogleCredential property in VertexAIConfiguration was updated to remove default initialization. In VertexAIProvider, the constructor now sets the GoogleCredential for the PredictionServiceClientBuilder, enhancing credential management.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant Config as VertexAIConfiguration
    participant Provider as VertexAIProvider
    participant Client as PredictionServiceClientBuilder

    App->>Config: Initialize configuration
    Config->>Config: Set GoogleCredential
    App->>Provider: Create instance of VertexAIProvider
    Provider->>Config: Retrieve GoogleCredential
    Provider->>Client: Set GoogleCredential
    Client->>Provider: Ready for API requests

Loading

Poem

🐇 In the garden of code, changes bloom bright,
Credentials now shine, reflecting the light.
No defaults to trip, explicit we tread,
With each little tweak, new paths we’ll spread!
Hopping through logic, with joy we embrace,
A springtime of coding, a delightful new space!
🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2f5836 and 749fb70.

Files selected for processing (2)

• src/Providers/Google.VertexAI/src/VertexAIConfiguration.cs (1 hunks)
• src/Providers/Google.VertexAI/src/VertexAIProvider.cs (1 hunks)

Additional comments not posted (2)

src/Providers/Google.VertexAI/src/VertexAIConfiguration.cs (1)

11-11: LGTM! Ensure explicit assignment of GoogleCredential.

The removal of the default initialization improves security by avoiding the use of potentially incorrect default credentials. Ensure that GoogleCredential is explicitly assigned before use.

src/Providers/Google.VertexAI/src/VertexAIProvider.cs (1)

15-15: LGTM! Properly configure GoogleCredential for authentication.

The addition of the GoogleCredential assignment ensures that the PredictionServiceClientBuilder is properly configured for authentication. This change is crucial for the proper functioning of the client.