Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest Emscripten #46

Closed
VirtualTim opened this issue Jul 25, 2019 · 10 comments
Closed

Update to the latest Emscripten #46

VirtualTim opened this issue Jul 25, 2019 · 10 comments
Labels

Comments

@VirtualTim
Copy link
Contributor

VirtualTim commented Jul 25, 2019

Currently the latest tag is sdk-tag-1.38.32-64bit. Emscripten is up to 1.38.42.

Is there any plan to update this image for the latest Emscripten?

@trzecieu
Copy link
Owner

Hi @VirtualTim,
Thank you for this report, I'm aware about issue and will work to fix it.
Due vacation I will handle this in ~2w. Cheers!

@VirtualTim
Copy link
Contributor Author

No worries. I appreciate the ETA.

@boardend
Copy link

Is #45 blocking the update to the latest version? (1.38.41)

Let me know if I can help with investigation or testing.

@trzecieu
Copy link
Owner

Hi @boardend indeed, those two issues are the same. Due personal reasons my time is very limited. Nonetheless, I'm dedicated in the remaining fraction of time to fix entire docker image pipeline.
Thank you for your offer.

@VirtualTim
Copy link
Contributor Author

So how's the progress going on this?
Anything I can do to help?

@trzecieu
Copy link
Owner

Hi, @VirtualTim I have a working solution with fastcomp compiler, I have one element which is too hacky to be published, as it points on some arbitrary version of binaryen, once this is solved it will be done.

trzecieu added a commit that referenced this issue Aug 29, 2019
* set 1.38.33 as ignored due probelm with dependencies
* added python3 and python3-pip to slim image
* mitigate new build system introduced by upstream project
* temporarely removed possibility to compile incoming + master
@trzecieu
Copy link
Owner

trzecieu commented Aug 29, 2019

Hi,
I fixed all related problems, sorry that it took so long, it was a nice puzzle to solve. At the moment I've started to rebuild all images 1.38.34 upwards. Will take a couple of hours until they land in registry,
At the moment you can check 1.38.40 as I was using it as a test case.

➜ docker run --rm -it trzeci/emscripten:sdk-tag-1.38.40-64bit emcc --version
Unable to find image 'trzeci/emscripten:sdk-tag-1.38.40-64bit' locally
sdk-tag-1.38.40-64bit: Pulling from trzeci/emscripten
9fc222b64b0a: ...
Digest: sha256:839c186ec629fcec7ebb5ad50b9a503415707d98cbdaa5afaf4d7e15555f1e7b
Status: Downloaded newer image for trzeci/emscripten:sdk-tag-1.38.40-64bit
emcc (Emscripten gcc/clang-like replacement) 1.38.40 ((unknown revision))
Copyright (C) 2014 the Emscripten authors (see AUTHORS.txt)
This is free and open source software under the MIT license.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Will keep this issue open for a couple of days to make sure everything works for you.
Cheers,

@trzecieu trzecieu added Done and removed In progress labels Aug 29, 2019
@VirtualTim
Copy link
Contributor Author

Awesome. Thanks Piotr. I should get a chance to test these out Monday.

@trzecieu
Copy link
Owner

trzecieu commented Sep 4, 2019

Should be done, please re-open in case of any problems,
Cheers!

@trzecieu trzecieu closed this as completed Sep 4, 2019
@VirtualTim
Copy link
Contributor Author

I switched over my builds to use 1.38.43 on Monday, and it all seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants