Prevent potential size overflow and 0 length PATCH #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing for your changes, which could indicate a problem. Also, in https://community.transloadit.com/t/how-to-abort-hanging-companion-uploads/16488/13 they mentioned that this behavior would occur when uploadSize was too big, so we should focus on fixing this. cc @jdcalvin |
|
Superseeded by #606. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: i'm not sure how to reproduce or even test this. and i'm not even sure if this is the correct solution, but I saw some code that I thought could be buggy.
alternatively we could throw an error if
sliceSize < 0oroffset > this._size, because that could indicate a logic issue.see discussion in https://community.transloadit.com/t/how-to-abort-hanging-companion-uploads/16488/10