Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Typeahead auto-selection #4162

Closed
sheeley opened this issue Jul 23, 2012 · 23 comments
Closed

Disabling Typeahead auto-selection #4162

sheeley opened this issue Jul 23, 2012 · 23 comments

Comments

@sheeley
Copy link

sheeley commented Jul 23, 2012

I'm working on a project where we're using Typeahead as auto-suggest, not the only options. The default behavior of selecting the first option can lead to undesirable behavior. Same thing for clearing the text box on enter if nothing is selected.

I'd be happy to submit changes in a pull request, is this something people would use/are interested in? Or have I missed something completely obvious that already exists?

@mwhitneysdsu
Copy link

I would also be interested in being able to change the behavior. I use them in a very similar fashion to what you describe, and the clearing on enter can be especially annoying. It's almost hostile to keyboard navigation, yet it doesn't offer a dropdown-style list on-click, either.

@ruant
Copy link

ruant commented Nov 6, 2012

This added feature would be super nice to get.

@SirZach
Copy link

SirZach commented Nov 30, 2012

I am in full support of such a feature. I am in the process of implementing this myself.

@sheeley
Copy link
Author

sheeley commented Nov 30, 2012

Cool - feel free to take a look at my fork, I've implemented what I was
looking for.

On Fri, Nov 30, 2012 at 11:25 AM, Zach McGonigal
notifications@gitpro.ttaallkk.topwrote:

I am in full support of such a feature. I am in the process of
implementing this myself.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4162#issuecomment-10900765.

@mdo
Copy link
Member

mdo commented Dec 2, 2012

I can see this being potentially useful, but most of the typeahead/autocompletes I use everyday autoselect the first item. Google Chrome does, Alfred.app does, and many more. However, Google.com doesn't.

If it can be done as an option, I'm game for adding it. Go ahead and submit a new PR and get some guidance from @fat before getting too far in.

@SirZach
Copy link

SirZach commented Dec 2, 2012

I added it as an option with autoSelect on by default. I'll submit a PR. I agree that most auto-select the first one by default but if you want any partial searching capability, you need it to not auto-select.

@Nelrann
Copy link

Nelrann commented Jan 12, 2013

+1

@marceloverdijk
Copy link

+1

What is the status of this?

@fat
Copy link
Member

fat commented Feb 8, 2013

if you really want this, i'd be down to review a pull request – otherwise not something we're going to spend much time on

@fat fat closed this as completed Feb 8, 2013
@sheeley
Copy link
Author

sheeley commented Feb 8, 2013

thanks - i opened a pull request. another dev also opened a request. these were both months ago, would love to see this get pushed into the framework!

@marceloverdijk
Copy link

Yes I noticed the pull request as well, that's why I was wondering what the status was.
This would be a very nice addition to typeahead!

@alexhanh
Copy link

+1

1 similar comment
@Empact
Copy link

Empact commented Mar 8, 2013

+1

@MarcDiethelm
Copy link

this is relevant to my interests.

@MrJohnsson77
Copy link

Yes please

@ricricucit
Copy link

+1

4 similar comments
@tyson-benson
Copy link

+1

@mb-dev
Copy link

mb-dev commented Mar 31, 2013

+1

@wpoulos
Copy link

wpoulos commented Apr 10, 2013

+1

@monorigabor
Copy link

+1

@cvrebert
Copy link
Collaborator

This issue has been made moot by #7805.

@reno1979
Copy link

reno1979 commented Jul 2, 2013

+1

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 3, 2013

@reno1979: Read #7805.

@twbs twbs locked and limited conversation to collaborators Jul 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests