Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10076: Document hide text #10100

Merged
merged 3 commits into from
Aug 24, 2013
Merged

Fixes #10076: Document hide text #10100

merged 3 commits into from
Aug 24, 2013

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 24, 2013

Fixes #10076.
This adds a missing helper class and mixin to the Helper classes section of the CSS page in our docs. The kicker is that the class and mixin are not the same name, unlike our other classes and mixins in the section (e.g., .pull-right is first a class but also mixin-able). This is confusing and super lame, so I've opted to deprecate the mixin and push folks to use the single class name.

// CSS image replacement
// Source: https://github.com/h5bp/html5-boilerplate/commit/aa0396eae757
.hide-text(),
.text-hide() {
  font: ~"0/0" a;
  color: transparent;
  text-shadow: none;
  background-color: transparent;
  border: 0;
}

// Applying the mixin
.text-hide {
  .text-hide();
}

That look about right @cvrebert?

@cvrebert
Copy link
Collaborator

Docs look good, but the LESS has a compile error; see Travis.

@mdo
Copy link
Member Author

mdo commented Aug 24, 2013

Herped and derped—all fixed. FYI your commit comment is no longer relevant since I changed the code shortly afterwards. Should be all set now with the deprecated mixin and Travis.

cvrebert added a commit that referenced this pull request Aug 24, 2013
@cvrebert cvrebert merged commit a7e5bac into master Aug 24, 2013
@cvrebert cvrebert deleted the document_hide_text branch August 24, 2013 05:39
@cvrebert
Copy link
Collaborator

👯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.text-hide not documented
2 participants