Removed the unnecessary override and the !important from .wrap #10729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the sticky footer example there were some weird stuff..
|
I imagine these were there for cross browser compatibility. Have you tried this in all the supported browsers (IE8+, latest Safari, Chrome, and Firefox)? |
|
Latest Safari, Chrome, Firefox on OS X works as expected.. |
|
Since this doesn't change IE8 at all (which is broken as it stands now), nor IE9 and any of the other browsers, we can merge this. Thanks! |
mdo
added a commit
that referenced
this pull request
Oct 21, 2013
Removed the unnecessary override and the !important from .wrap
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sticky footer example there were some weird stuff..