Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore grid mixins #11050

Merged
merged 4 commits into from
Oct 14, 2013
Merged

Restore grid mixins #11050

merged 4 commits into from
Oct 14, 2013

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 12, 2013

Combines the efforts of #9970 and #10055 to fix #9436.

There were a few things I like about both approaches, and so I spent a few minutes bringing the two together for a more cohesive grid system generator. It's still a bit hairy, but I'm hoping some folks with more mixin chops can help me see if there is room for improvement.

A few thoughts, comments, caveats, etc:

  • We cannot use attribute selectors (meaning no [class^="col-"])
  • We cannot float everything all the time, that breaks the stacking of columns below their breakpoints (e.g., a medium grid column should be stacked in small view ports)
  • The number of mixins is kind of outrageous for generating our mixins and providing generic mixins to generate your own classes. I'm unsure of a way to improve this :.

That said, this brings back an amazing tool for folks and I think no matter how it changes from here, it's a solid win for 3.0.1.

/cc @cvrebert @masterbee

Conflicts:
	dist/css/bootstrap.min.css
Conflicts:
	dist/css/bootstrap.min.css
@mdo
Copy link
Member Author

mdo commented Oct 14, 2013

This should also address #10152 and #9436, btw.

mdo added a commit that referenced this pull request Oct 14, 2013
@mdo mdo merged commit a436964 into master Oct 14, 2013
@mdo mdo deleted the restore_grid_mixins branch October 14, 2013 02:03
@mdo mdo mentioned this pull request Oct 21, 2013
@cvrebert cvrebert mentioned this pull request Oct 21, 2013
@christhesoul
Copy link

Is it going to be possible to offset at xs size but remove it from sm upwards? Can't seem to override with col-sm-offset-0 or similar.

@cvrebert
Copy link
Collaborator

@christhesoul That should work as of v3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore grid mixins
3 participants