Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font style utilities did not contained "-style-" in BS4 #37361

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Oct 24, 2022

Description

CSS font style utility classes are named .font-italic and .font-normal in Bootstrap 4. The migration guides for Bootstrap 5 wrongly reference them as .font-style-*.

Motivation & Context

This fixes an error in the Bootstrap 5 migration guides.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants