Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add Border radius section for Input group #40776

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TommasoAllegretti
Copy link
Contributor

@TommasoAllegretti TommasoAllegretti commented Aug 27, 2024

Description

I added a Border radius section in the Input group docs to explicitly show how that style is applied to the children elements.

I might have given too much importance to the section because I wanted the behavior to be clear to newcomers and avoid any confusion, but I could see how the same information could be delivered just by adding a single line in the Basic example section.

Please let me know if there is anything I can improve with my solution.

Type of changes

  • Documentation enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40763

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the implementation, waiting for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outer right border radius not applied to datalist in an input group
2 participants