Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve label of copy/stackblitz buttons for accessibility #40820

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hannahiss
Copy link
Contributor

@hannahiss hannahiss commented Sep 12, 2024

Description

⚠️ 🚧 DRAFT 🚧⚠️ Just testing for now

Added discriminating information to the label of the "Edit in Stackblitz" and "Copy to clipboard" buttons of examples, to know exactly what they correspond to.

This is a first version to validate the principle, with an example on Accordion component, before doing it everywhere (huge work).

I also have to check if it is possible to propose something for the copy buttons outside of the example shortcode (like in Getting started) which are not implemented the same way.

Motivation & Context

All "Edit in Stackblitz" and "Copy to clipboard" buttons had the same labels, making it impossible to do the difference between the examples.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Asked while discussing in #40766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant