Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use textContent when innerText is not available. #518

Merged
merged 1 commit into from
Apr 1, 2014
Merged

Conversation

XhmikosR
Copy link
Member

Firefox does not implement innerText so this led to another TypeError: data.title.innerText is undefined.

/CC @connors @fat

@XhmikosR XhmikosR added the js label Mar 27, 2014
@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 27, 2014
@XhmikosR XhmikosR self-assigned this Mar 27, 2014
@connors
Copy link
Collaborator

connors commented Mar 28, 2014

I'm good as long as @connor and @fat don't see anything wrong.

@XhmikosR XhmikosR mentioned this pull request Mar 29, 2014
@XhmikosR
Copy link
Member Author

Well, it works :D

Sure, we could use jQuery's text or something, but doesn't seem the core code's using jQuery so I went with this approach.

Firefox does not implement `innerText` so this led to another `TypeError`.
XhmikosR added a commit that referenced this pull request Apr 1, 2014
Use `textContent` when `innerText` is not available.
@XhmikosR XhmikosR merged commit 62f5f9f into master Apr 1, 2014
@XhmikosR XhmikosR deleted the innerText branch April 1, 2014 05:19
@connors connors mentioned this pull request Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants