Don't let comments escape from empty export lists #1013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #906, see #933 (comment) for more context. The main advantage of this PR to #933 is that it is much more minimal, bu it is still relatively ad-hoc.
There is a similar issue in other cases, e.g. also with this PR (or also with #933), comments "escape" here:
See 54dfe3e for an approach to call
encloseLocated
"automatically" via an overlapping instance, which e.g. "catches" the comment in the first case in the example above. The other two would probably need ad-hoc handling inp_rdrName
.