Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not blow up on Addressable::IDNA::PunycodeBigOutput #113

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Do not blow up on Addressable::IDNA::PunycodeBigOutput #113

merged 2 commits into from
Mar 23, 2017

Conversation

dentarg
Copy link
Collaborator

@dentarg dentarg commented Mar 23, 2017

Related to #112.

@dentarg dentarg merged commit f9e82d4 into master Mar 23, 2017
@dentarg dentarg deleted the rescue-idna-punycode-big-output branch March 23, 2017 12:01
dentarg added a commit that referenced this pull request Feb 28, 2018
@dentarg
Load the pure-Ruby IDNA implementation from Addressable
f38152c 
Since #113, twingly-url can only be used with the pure-Ruby
implementation in Addressable.

If idn-ruby (libidn wrapper gem) is installed, Addressable will not load
the pure-Ruby implementation, which breaks twingly-url.

Close #119
@dentarg dentarg mentioned this pull request Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jage jage jage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dentarg @jage