Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure normalized IDNA domains return ASCII strings #90

Merged
merged 23 commits into from
Sep 15, 2016
Merged

Commits on Sep 9, 2016

  1. Use PublicSuffix 2

    Related to #89 and #71.
    
    Close #85.
    dentarg committed Sep 9, 2016
    Configuration menu
    Copy the full SHA
    cd38e55 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2016

  1. Reindex the PSL only one time

    "bundle exec rspec spec/lib/twingly/url_spec.rb" went from
    
        files took 1.72 seconds to load
    
    to
    
        files took 0.27164 seconds to load
    dentarg committed Sep 10, 2016
    Configuration menu
    Copy the full SHA
    2bd6447 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2353593 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2016

  1. Configuration menu
    Copy the full SHA
    f085c62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba0002b View commit details
    Browse the repository at this point in the history
  3. Tweak "inspect PSL command"

    My shell is a bit fancy, and with the old versions I got this:
    
        $ cat `bundle show public_suffix`/data/list.txt | wc -l
        preexec: command not found: bundle
           11618
    dentarg committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    825006a View commit details
    Browse the repository at this point in the history
  4. Improve normalizing valid URLs test case

    Catch valid URLs being normalized to something that's parsed as NullURL.
    dentarg committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    da00c54 View commit details
    Browse the repository at this point in the history
  5. Improve URL comment

    dentarg committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    bc7ea49 View commit details
    Browse the repository at this point in the history
  6. Document the current behaviour with libidn

    Currently, this URL isn't valid, but if we drop libidn (which we talked
    about), it would be valid, due to the way Addressable 2.4.0 works.
    See comment at: #66 (comment)
    
    Adding this URL to the tests so we will notice the change in behaviour,
    if/when we drop libidn.
    dentarg committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    2d56c5b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2016

  1. Use more correct regexp to find IDN ccTLDs

    The ACE prefix is always in the beginning, thus we need to check the
    beginning of each part.
    
    https://en.wikipedia.org/wiki/Internationalized_domain_name#ToASCII_and_ToUnicode
    dentarg committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    6cdbf85 View commit details
    Browse the repository at this point in the history
  2. Add missing word to README

    dentarg committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    e47e0f1 View commit details
    Browse the repository at this point in the history
  3. Fix typo in README

    dentarg committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    46a4175 View commit details
    Browse the repository at this point in the history
  4. Be picky about the version of our dependencies

    Set the latest version as the minimum (because that's the one that was
    used when developing and testing twingly-url), but allow for usage of
    later non-major versions, to be able to update the version of these gems
    in projects using twingly-url, without requiring a new twingly-url
    release.
    
    http://guides.rubygems.org/patterns/
    
    Didn't touch idn-ruby because there's currently only one version, 0.1.0,
    released: https://rubygems.org/gems/idn-ruby/versions
    dentarg committed Sep 13, 2016
    2 Configuration menu
    Copy the full SHA
    b61f962 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2016

  1. Test all relevant parts of normalized IDN

    Close #89.
    dentarg committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    765db07 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9d2fb5 View commit details
    Browse the repository at this point in the history
  3. Improve readability

    dentarg committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    ba6c5a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2016

  1. Configuration menu
    Copy the full SHA
    15414ed View commit details
    Browse the repository at this point in the history
  2. DRY up to urls example

    This will print userinfo, user and password for all URLs, which it
    didn't do before.
    jage committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    5b615d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdcd70b View commit details
    Browse the repository at this point in the history
  4. DRY up to urls example (#95)

    * DRY up to urls example
    * Print the same example methods for all URLs in the README
    jage authored Sep 15, 2016
    Configuration menu
    Copy the full SHA
    640f88c View commit details
    Browse the repository at this point in the history
  5. Add normalized examples

    dentarg committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    6bd71e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    900350c View commit details
    Browse the repository at this point in the history
  7. Add #to_s to examples

    dentarg committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    c0b5235 View commit details
    Browse the repository at this point in the history