-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure normalized IDNA domains return ASCII strings #90
Merged
Commits on Sep 9, 2016
-
Configuration menu - View commit details
-
Copy full SHA for cd38e55 - Browse repository at this point
Copy the full SHA cd38e55View commit details
Commits on Sep 10, 2016
-
"bundle exec rspec spec/lib/twingly/url_spec.rb" went from files took 1.72 seconds to load to files took 0.27164 seconds to load
Configuration menu - View commit details
-
Copy full SHA for 2bd6447 - Browse repository at this point
Copy the full SHA 2bd6447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2353593 - Browse repository at this point
Copy the full SHA 2353593View commit details
Commits on Sep 12, 2016
-
Configuration menu - View commit details
-
Copy full SHA for f085c62 - Browse repository at this point
Copy the full SHA f085c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba0002b - Browse repository at this point
Copy the full SHA ba0002bView commit details -
My shell is a bit fancy, and with the old versions I got this: $ cat `bundle show public_suffix`/data/list.txt | wc -l preexec: command not found: bundle 11618
Configuration menu - View commit details
-
Copy full SHA for 825006a - Browse repository at this point
Copy the full SHA 825006aView commit details -
Improve normalizing valid URLs test case
Catch valid URLs being normalized to something that's parsed as NullURL.
Configuration menu - View commit details
-
Copy full SHA for da00c54 - Browse repository at this point
Copy the full SHA da00c54View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7ea49 - Browse repository at this point
Copy the full SHA bc7ea49View commit details -
Document the current behaviour with libidn
Currently, this URL isn't valid, but if we drop libidn (which we talked about), it would be valid, due to the way Addressable 2.4.0 works. See comment at: #66 (comment) Adding this URL to the tests so we will notice the change in behaviour, if/when we drop libidn.
Configuration menu - View commit details
-
Copy full SHA for 2d56c5b - Browse repository at this point
Copy the full SHA 2d56c5bView commit details
Commits on Sep 13, 2016
-
Use more correct regexp to find IDN ccTLDs
The ACE prefix is always in the beginning, thus we need to check the beginning of each part. https://en.wikipedia.org/wiki/Internationalized_domain_name#ToASCII_and_ToUnicode
Configuration menu - View commit details
-
Copy full SHA for 6cdbf85 - Browse repository at this point
Copy the full SHA 6cdbf85View commit details -
Configuration menu - View commit details
-
Copy full SHA for e47e0f1 - Browse repository at this point
Copy the full SHA e47e0f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46a4175 - Browse repository at this point
Copy the full SHA 46a4175View commit details -
Be picky about the version of our dependencies
Set the latest version as the minimum (because that's the one that was used when developing and testing twingly-url), but allow for usage of later non-major versions, to be able to update the version of these gems in projects using twingly-url, without requiring a new twingly-url release. http://guides.rubygems.org/patterns/ Didn't touch idn-ruby because there's currently only one version, 0.1.0, released: https://rubygems.org/gems/idn-ruby/versions
2Configuration menu - View commit details
-
Copy full SHA for b61f962 - Browse repository at this point
Copy the full SHA b61f962View commit details
Commits on Sep 14, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 765db07 - Browse repository at this point
Copy the full SHA 765db07View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9d2fb5 - Browse repository at this point
Copy the full SHA d9d2fb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba6c5a4 - Browse repository at this point
Copy the full SHA ba6c5a4View commit details
Commits on Sep 15, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 15414ed - Browse repository at this point
Copy the full SHA 15414edView commit details -
This will print userinfo, user and password for all URLs, which it didn't do before.
Configuration menu - View commit details
-
Copy full SHA for 5b615d1 - Browse repository at this point
Copy the full SHA 5b615d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdcd70b - Browse repository at this point
Copy the full SHA bdcd70bView commit details -
* DRY up to urls example * Print the same example methods for all URLs in the README
Configuration menu - View commit details
-
Copy full SHA for 640f88c - Browse repository at this point
Copy the full SHA 640f88cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bd71e7 - Browse repository at this point
Copy the full SHA 6bd71e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 900350c - Browse repository at this point
Copy the full SHA 900350cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0b5235 - Browse repository at this point
Copy the full SHA c0b5235View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.