Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Green up the build #87

Merged
merged 5 commits into from
May 6, 2024
Merged

Green up the build #87

merged 5 commits into from
May 6, 2024

Conversation

twm
Copy link
Contributor

@twm twm commented May 6, 2024 •
edited
Loading

  • Add Python 3.10, 3.11, and 3.12 to the test matrix.
  • Drop Python 2.7 as GHA no longer provides it. It hasn't been formally deprecated, but I don't think this is too terrible as it's been EoL for a long time now.
  • Yoink GHA coverage reporting from #11744 Generate coverage report using only GitHub Actions twisted#11745 because Codecov was failing and I refuse to deal with it.
  • Fix the Tox config to specify Tox < 3 so that the tests run locally.

Fixes #86. Fixes #85.

@twm twm changed the title Add Python 3.10, 3.11, and 3.12 to the build matrix Green up the build May 6, 2024
@twm twm requested a review from a team May 6, 2024 05:49
adiroiban
adiroiban approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

I am going to merge this now to get trunk pass.

@adiroiban adiroiban merged commit 98fcde2 into trunk May 6, 2024
10 checks passed
@adiroiban adiroiban deleted the 86-test-matrix branch May 6, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test with Python 3.10, 3.11, and 3.12 GitHub Action test run failing on the main branch
2 participants
@twm @adiroiban