Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that it only works with NSS #33

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Otto-AA
Copy link
Contributor

@Otto-AA Otto-AA commented Feb 20, 2023

Looking at auth.py this project relies on a /login/password endpoint and the nssidp.sid cookie. I think both of these are not standardized and only work with NSS (at least nssidp.sid suggests it is NSS specific).

It would make sense to clarify this in the README so users don't get wrong expectations (as in #30).

@hrchu
Copy link
Member

hrchu commented Feb 20, 2023

LGTM. @peter0083 could you merge this PR if you feel comfortable with it?

@hrchu
Copy link
Member

hrchu commented Feb 20, 2023

Solid authentication standard is not ready to use in production back to two years ago (see issue #3 ). The basic auth we implemented was the only way to do authentication at that time (except javascript libs).

We actually mentioned the limitation clearly in the document (see the Access private resources in https://github.com/twonote/solid-file-python/blob/master/solid-file-python-getting-start.ipynb)

However, it is nice to see the limitation more clearly from the user's perspective.

@hrchu
Copy link
Member

hrchu commented Feb 20, 2023

@Otto-AA would you like to contribute to Solid-OIDC support for the Python ecosystem? I believe it can make a huge impact both on Solid and Python communities.

@Otto-AA
Copy link
Contributor Author

Otto-AA commented Feb 20, 2023

Thanks for the quick responses!

@Otto-AA would you like to contribute to Solid-OIDC support for the Python ecosystem? I believe it can make a huge impact both on Solid and Python communities.

If I have time sure, but I don't know when this will be 🙃

I guess I'm too good at procrastinating other stuff. So here it is: https://pypi.org/project/solid-oidc-client/

It's based on the work by Rai with solid-flask, but extracted as a library and a lot of refactoring. It works with all pods (ESS, NSS, CSS). Feel free to test it and to integrate it with solid-file-python :)

@renyuneyun
Copy link
Contributor

renyuneyun commented Oct 23, 2023

There is also this Python project for Solid OIDC, which seems to be more complete?: https://github.com/trompamusic/solid-oidc-app-permission
Never mind. That project seems to be a server implementation/mockup, not client.

@Otto-AA
Copy link
Contributor Author

Otto-AA commented Oct 27, 2023

There is also this Python project for Solid OIDC, which seems to be more complete?: https://github.com/trompamusic/solid-oidc-app-permission
Never mind. That project seems to be a server implementation/mockup, not client.

As mentioned in the forum thread, I think it acts as a client for the Solid OIDC protocol, ie it is not an identity provider, but tries to login a user to an existing IDP through Solid-OIDC.

@renyuneyun
Copy link
Contributor

Just for information: I created a PR #38 which integrates solid-oidc-client with this library. It's working, but not entirely complete as of the discussion points.

@peter0083 peter0083 requested a review from hrchu October 31, 2023 03:59
@peter0083
Copy link
Contributor

Looks good to me. Merging this PR. Thank you for your contribution @renyuneyun !

@peter0083 peter0083 merged commit 5243b84 into twonote:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants