[2/x] Fix optional members in Obj-C protocols #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmeisters
approved these changes
Jan 28, 2022
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-multiproj-caching
branch
from
f75db97
to
8d1607b
Compare
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-objc-protocols
branch
from
36896af
to
8fef295
Compare
Base automatically changed from
dev/andrewchang-bird/fix-multiproj-caching
to
master
January 28, 2022 23:16
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-objc-protocols
branch
from
8fef295
to
323bea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
📚 #279 ← [2/x] Fix optional members in Obj-C protocols
📚 #278 [1/x] Fix cross-project cache invalidation
Overview
Generating Swift mocks for Objective-C annotated protocols with optional members regressed in 0.18 due to invocation forwarding for partial mocks. This PR allows the generator to explicitly handle optional members and improves the overall Objective-C compatibility.
Test Plan
Added an additional test case for Objective-C protocols.