Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding note to testing.md about qunit-dom #1562

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Adding note to testing.md about qunit-dom #1562

merged 1 commit into from
Sep 29, 2023

Conversation

tsengia
Copy link
Contributor

@tsengia tsengia commented Jun 30, 2023

This PR just adds a small snippet to the testing.md page about importing qunit-dom so that Typescript is aware of the assert.dom() function commonly used in Component tests.

It took me a while to figure this out, so I hope that this small snippet can save others some time in the future.

Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is good to have here. qunit-dom's own docs also cover this, and I believe the blueprints shipped in ember-source do the right thing, but this is great to have. Thanks!

@chriskrycho chriskrycho merged commit 30b269b into typed-ember:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants