Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current Node LTS #1570

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Use the current Node LTS #1570

merged 2 commits into from
Oct 10, 2023

Conversation

chriskrycho
Copy link
Member

Note: This is a breaking change! However, it is only breaking in a strict sense, and no runtime behavior should be different.

Note: This is a breaking change! However, it is only breaking in a strict
sense, and no runtime behavior should be different.
@chriskrycho chriskrycho added the BREAKING This is a breaking change! Do not merge without major version release. label Sep 28, 2023
@NullVoxPopuli
Copy link
Collaborator

We have a bit of a catch-22 -- the floating dependencies tests are not capable of passing until this is merged. But this typically can't merge until CI passes. So, we're going to have red c.i. for a smidge. Going to merge after changing the node version to 18.18.1 from 18.18.0, as .0 had a bug that affected ember projects.

@NullVoxPopuli
Copy link
Collaborator

hm, merge queue isn't going to work here

@NullVoxPopuli NullVoxPopuli merged commit cde9d08 into master Oct 10, 2023
6 of 9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the node-version branch October 10, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING This is a breaking change! Do not merge without major version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants