Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-source-channel-url because ember-cli is too new now #1571

Closed
wants to merge 11 commits into from
Closed
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ jobs:
fail-fast: false
matrix:
deps:
- ember-cli@latest
- ember-cli@beta
- typescript@latest
- typescript@next
- ember-cli-release
- ember-cli-beta
- typescript-release
- typescript-beta
steps:
- name: Checkout Code
uses: actions/checkout@v2
Expand All @@ -99,9 +99,11 @@ jobs:
- name: Raise Watched File Limit
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
- name: Install Dependencies
run: yarn add --dev ${{ matrix.deps }}
run: yarn install
- name: Prepare CI Environment
run: yarn ci:prepare
run: |
yarn prepublishOnly
yarn ember try:one ${{matrix.deps}} --skip-cleanup --- echo 'setup'
- name: Ember App Tests
run: yarn ci:test:app
- name: Node Tests
Expand Down
88 changes: 54 additions & 34 deletions config/ember-try.js
Original file line number Diff line number Diff line change
@@ -1,44 +1,64 @@
module.exports = {
useYarn: true,
command: 'yarn ci:test',
scenarios: [
{
name: 'defaults',
npm: {
devDependencies: {},
const getChannelUrl = require('ember-source-channel-url');

module.exports = async function () {
const ember5Deps = {
'@ember/string': '^3.1.1',
'@ember/test-helpers': '^3.2.0',
'ember-cli-htmlbars': '^6.3.0',
'ember-cli-babel': '^8.0.0',
'ember-qunit': '^8.0.0',
'ember-resolver': '^11.0.0',
'ember-auto-import': '^2.3.0',
'ember-maybe-import-regenerator': null,
'ember-cli-app-version': null,
};

return {
useYarn: true,
command: 'yarn ci:test',
scenarios: [
{
name: 'defaults',
npm: {
devDependencies: {},
},
},
},
{
name: 'typescript-release',
npm: {
devDependencies: {
typescript: 'latest',
{
name: 'typescript-release',
npm: {
devDependencies: {
typescript: 'latest',
},
},
},
},
{
name: 'typescript-beta',
npm: {
devDependencies: {
typescript: 'next',
{
name: 'typescript-beta',
npm: {
devDependencies: {
typescript: 'next',
},
},
},
},
{
name: 'ember-cli-release',
npm: {
devDependencies: {
'ember-cli': 'latest',
{
name: 'ember-cli-release',
npm: {
devDependencies: {
'ember-cli': 'latest',
'ember-source': await getChannelUrl('release'),
...ember5Deps,
},
},
},
},
{
name: 'ember-cli-beta',
npm: {
devDependencies: {
'ember-cli': 'beta',
{
name: 'ember-cli-beta',
npm: {
devDependencies: {
'ember-cli': 'beta',
'ember-source': await getChannelUrl('beta'),
...ember5Deps,
},
},
},
},
],
],
};
};
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"ember-cli-app-version": "4.0.0",
"ember-cli-babel": "7.23.0",
"ember-cli-blueprint-test-helpers": "0.19.2",
"ember-cli-dependency-checker": "3.2.0",
"ember-cli-dependency-checker": "3.3.2",
"ember-cli-htmlbars": "5.3.1",
"ember-cli-inject-live-reload": "2.0.2",
"ember-cli-sri": "2.1.1",
Expand All @@ -99,7 +99,8 @@
"ember-qunit": "4.6.0",
"ember-resolver": "8.0.2",
"ember-source": "~3.28.0",
"ember-try": "1.4.0",
"ember-source-channel-url": "^3.0.0",
"ember-try": "3.0.0",
"eslint": "8.7.0",
"eslint-config-prettier": "8.3.0",
"eslint-plugin-ember": "10.5.8",
Expand Down
Loading
Loading