Improve types for DiscoverRunner #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
discover_runner
branch
from
3732bca
to
c7f0f1e
Compare
sobolevn
approved these changes
Aug 26, 2022
sobolevn
reviewed
Aug 26, 2022
|
From now on, I will run at least some tests locally before making a PR 😅😅😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
PDBDebugResult- missing result class related to the--pdbflag. I noticed thatDebugSQLTextTestResultrepeats hints for things inherited fromTextTestResult- why is that? I didn't do that forPDBDebugResult...test_suite,parallel_test_suite,test_runner,test_loader,reorder_by- add real types rather thanAnypdb,test_name_patterns,buffer- args added in Large update #909 but attribute missedtime_keeper- attribute that relates to thetimingflaglogger,shuffle,shuffle_seed,log,setup_shuffler- args, attributes, and methods from Django 4.0: https://docs.djangoproject.com/en/4.0/releases/4.0/#testsload_with_patterns,load_tests_for_label,_get_databases- some missing methodsRelated issues
n/a