Remove bad redirect_chain attributes #1148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
redirect_chain
is monkey-patched on by the test client. I added it in #1124 . I just spotted there are badredirect_chain
attributes declared on the baseHttpResponse
andTemplateResponse
classes, added in fa718b8. These are not generally there, only the monkey-patching adds them, so we should remove these declarations.Related issues
Looking at #1085 made me check the history.