Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.json #748

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Update node.json #748

merged 1 commit into from
Sep 2, 2016

Conversation

blakeembrey
Copy link
Member

Typings URL: https://github.com/types/env-node

Change Summary (for existing typings):

Tidied up a couple of types: https://github.com/types/env-node/commits/master.

@blakeembrey blakeembrey merged commit 8b2e59e into master Sep 2, 2016
@blakeembrey blakeembrey deleted the blakeembrey-patch-1 branch September 2, 2016 02:22
@nickzelei
Copy link
Contributor

nickzelei commented Sep 2, 2016

This merge has broken all of my projects that are using the env-node typings. It has specifically broken references to the "express-serve-static-core" project as well as the "types-is" project.

I'm working on Node 4.x

@blakeembrey
Copy link
Member Author

@Zelein Are these projects from DefinitelyTyped? I removed the deprecated methods because of exactly this reason, they kept being used and shouldn't be. Express has correct definitions under npm, and I can type type-is today if that is helpful.

@nickzelei
Copy link
Contributor

Typing out the type-is would be very helpful if you can spare the time for
it. We have an internal declaration file, but it is basic and out of date.

The more I'm using TS the more I'm seeing the typings declarations to be
much more up to date than their DT counterparts.

On Sep 2, 2016 18:21, "Blake Embrey" notifications@github.com wrote:

@Zelein https://github.com/zelein Are these projects from
DefinitelyTyped? I removed the deprecated methods because of exactly this
reason, they kept being used and shouldn't be. Express has correct
definitions under npm, and I can type type-is today if that is helpful.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#748 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACTt0Sqbb7fChRCOTF-Bwv8SLZXkqLiaks5qmK97gaJpZM4JzTtb
.

@blakeembrey
Copy link
Member Author

@Zelein Sorry for the delay, it took me days to finish the RethinkDB typings (it's insane!). I quickly typed out type-is, you can see the definition here: https://github.com/types/npm-type-is. It's a pretty small one 😄

@nickzelei
Copy link
Contributor

Thank you @blakeembrey. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants