Skip to content

Commit

Permalink
e2fsck: fix golden output of several tests
Browse files Browse the repository at this point in the history
Some old tests of EA inodes were not in fact completely fixing the
filesystem (like they were leaving directories with EA_INODE_FL set or
EA inodes referenced from directory hierarchy). New e2fsck checks fix
these so golden output changes. Update it.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240506174132.12883-3-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  • Loading branch information
jankara authored and tytso committed May 9, 2024
1 parent eb01b6e commit 7b2e837
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/f_bad_disconnected_inode/expect.1
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
Pass 1: Checking inodes, blocks, and sizes
Inode 1 has the ea_inode flag set but is not a regular file. Clear flag? yes

Inode 1 has EXTENTS_FL flag set on filesystem without extents support.
Clear? yes

Inode 9 has the casefold flag set but is not a directory. Clear flag? yes

Inode 10 has the ea_inode flag set but is not a regular file. Clear flag? yes

Inode 14 has the casefold flag set but is not a directory. Clear flag? yes

Inode 14 has the ea_inode flag set but is not a regular file. Clear flag? yes

Inode 14 has INLINE_DATA_FL flag on filesystem without inline data support.
Clear? yes

Expand All @@ -14,6 +20,8 @@ Clear? yes

Inode 16 has the casefold flag set but is not a directory. Clear flag? yes

Inode 16 has the ea_inode flag set but is not a regular file. Clear flag? yes

Inode 16 has INLINE_DATA_FL flag on filesystem without inline data support.
Clear? yes

Expand Down
2 changes: 2 additions & 0 deletions tests/f_bad_fname/expect.1
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
Pass 1: Checking inodes, blocks, and sizes
Inode 12 has the ea_inode flag set but is not a regular file. Clear flag? yes

Pass 2: Checking directory structure
Entry 'AM-^?' in /ci_dir (12) has illegal UTF-8 characters in its name.
Fix? yes
Expand Down
2 changes: 2 additions & 0 deletions tests/f_ea_inode_self_ref/expect.1
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ Clear? yes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Regular filesystem inode 16 has EA_INODE flag set. Clear? yes

Pass 5: Checking group summary information
Block bitmap differences: -20
Fix? yes
Expand Down

0 comments on commit 7b2e837

Please sign in to comment.