We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal.Stop(recv.signals)
Describe the bug
signalReceivers should call Signal.Stop(recv.signals) when they are Stop()ed.
Stop()
Because if not, then when a user does:
app.Start(...) app.Close(...) // block on anything else select {} // for example
the program will fail to exit when the user presses ctrl-c. Which is contrary to what one would expect after starting and stopping the fx app.
To Reproduce
Example
func main() { app := fx.New() app.Start(context.Background()) app.Stop(context.Background()) select {} }
ctrl-c should exit the program
Expected behavior the signal handler reverts back to Go's default signal handler
Additional context should be a ~1 line change :)
The text was updated successfully, but these errors were encountered:
Call signal.Stop when signalReceivers is stopped (#1198)
cb9cccf
fixes #1197 --------- Co-authored-by: Jacob Oaks <joaks@uber.com>
Successfully merging a pull request may close this issue.
Describe the bug
signalReceivers should call
Signal.Stop(recv.signals)
when they areStop()
ed.Because if not, then when a user does:
the program will fail to exit when the user presses ctrl-c. Which is contrary to what one would expect after starting and stopping the fx app.
To Reproduce
Example
ctrl-c should exit the program
Expected behavior
the signal handler reverts back to Go's default signal handler
Additional context
should be a ~1 line change :)
The text was updated successfully, but these errors were encountered: