Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/sidebar: Move concepts before features #1164

Merged

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Feb 18, 2024

In reading order, concepts like container and lifecycle
should come before we talk about parameter objects, value groups, etc.
(It's also okay to merge concepts and features, but I'm not doing that
here.)

Separately, make the lifecycle page appear as "Lifecycle" in the sidebar
while still having the title "Application Lifecycle".

In reading order, concepts like container and lifecycle
should come before we talk about parameter objects, value groups, etc.
(It's also okay to merge concepts and features, but I'm not doing that
here.)

Separately, make the lifecycle page appear as "Lifecycle" in the sidebar
while still having the title "Application Lifecycle".
@abhinav
Copy link
Collaborator Author

abhinav commented Feb 18, 2024

image

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91121fc) 98.78% compared to head (b1da6fb) 98.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1164   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          30       30           
  Lines        3057     3057           
=======================================
  Hits         3020     3020           
  Misses         30       30           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobOaks JacobOaks merged commit aa2324e into uber-go:master Feb 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants