Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.22, 1.23 #1235

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Upgrade to Go 1.22, 1.23 #1235

merged 1 commit into from
Aug 27, 2024

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Aug 27, 2024

Go 1.23 is out, so we can change supported versions to 1.22 and 1.23.
Switch CI to test against 1.22 and 1.23 only,
and merge test files that were previously split on Go versions
back together.

Go 1.23 is out, so we can change supported versions to 1.22 and 1.23.
Switch CI to test against 1.22 and 1.23 only,
and merge test files that were previously split on Go versions
back together.
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (67ed361) to head (73f055e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          35       35           
  Lines        2918     2918           
=======================================
  Hits         2872     2872           
  Misses         38       38           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobOaks JacobOaks merged commit 27eba7c into uber-go:master Aug 27, 2024
12 checks passed
@@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: ["ubuntu-latest", "windows-latest"]
go: ["1.21.x", "1.22.x"]
go: ["1.22.x", "1.23.x"]
Copy link

@rabbbit rabbbit Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    strategy:
      matrix:
        go: ["stable", "oldstable"]

and then

 go-version: ${{ matrix.go }}
if: matrix.latest

below? Or do we want to control this individually?

(https://github.com/uber-go/ratelimit/blob/main/.github/workflows/test.yaml)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I don't have a big preference. Sometimes the latest version breaks some tests, and sometimes upgrading involves removing some old build-tagged tests (e.g., this PR). So in that vein it makes sense to make upgrading an explicit action/PR. On the other hand, this would reduce manual ops work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable oldstable is also a valid option here. I'll defer to you on whether you want that or not.

@abhinav abhinav deleted the abg/go1.23 branch August 27, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants